Desktop: Fixes #10668: Tags and Delete note not being available on Search and on All Notes list

[pedr]

Fixes #10668

Description

The issue existed because the state selectedFolderId doesn't change when we select All Notes or do a Search. Since we use the selectedFolderId to check if it is identical to the static trash id to identify if we are in the "Trash context", switching from Trash to all notes was like we were still in the same context.

Testing

Test case 1

1. Go to Trash
2. Go to All notes
3. Right-click on a note in Note list : Delete note and Tags action should be available and not greyed out

Test case 2

1. Go to Trash
2. Go to All notes
3. Make a Search for some note that exists
4. Right-click on a note in Note list : Delete note and Tags actions should be available and not greyed out

[pedr]

• Write it down why the inTrash breaks when we set isSmartFilter is used

I changed how the inTrash enabled condition is defined, but now when we are in the All notes the option to permanently delete note is available in the menu

My solution was to separate the logic of itemIsReadOnlySync by moving the "note is read only because is shared" into another function.

That means that I had to update all enabled conditions that used noteIsReadOnly and folderIsReadOnly to also check if the selected note/folder is not on trash. This is more verbose, but it is the only way I found not to enable Permanently delete note for all notes.

Of course, for the Permanenly delete note the logic is different, we are checking if the note is not read-only AND is on Trash.

[pedr]

• Test again if you can move folder out of trash
• Revert the change to make permanently delete note not be able to delete any notes, and add logic inside the command.

[laurent22]

There's already a check on deleted_time here. Couldn't you just add a check on the selected note?

[pedr]

That's right, I just kept the check for the selectedNote object in this case and included it in the original inTrash boolean logic.

[pedr]

• Add test for inTrash definition

[pedr]

@laurent22 I added basic tests like suggested before

[laurent22]

Please use plain English for the titles. Don't use variable names or at least try to avoid this - this is meant to be a high level description of the test. It should show your intention which hopefully can be expressed in English. For example "deleted_time" is "0" means note is deleted, "selectedFolderId is not trash" means the selected folder is not the trash, etc.

[laurent22]

Looks good now, thanks Pedro!