Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Accessibility: Add missing labels and role information to several controls #10788

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request improves the accessibility of the desktop app. In particular, it,

  • Marks command-based buttons as buttons — previously, they were marked as links and "disabled" wasn't read by the screen reader.
  • Adds labels to buttons in the note properties dialog.
  • Marks the table in the note properties dialog as a table.
  • Adds labels to the "shared" and note count fields in the notebook list.
  • Adds a label to the "search" and "clear search" buttons in the note list.

Manual testing

Limited manual testing has been done on MacOS:

  • Verified that the the note properties dialog edit, copy, and save buttons have labels that are read by the screen reader.
  • Verified that the "search" button above the note list is read as having a "search" label.
  • Verified that a shared notebook is read as shared when focused in the notebook sidebar.
  • Verified that a disabled command button (forward) is read as "dimmed".

@laurent22 laurent22 merged commit b108bf7 into laurent22:dev Jul 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants