Desktop: Accessibility: Improve settings screen keyboard navigation and screen reader accessibility #10812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes several changes to the settings screen:
settingToComponent
function to a separate component. (Commit 5e94b46).ConfigScreen.tsx
and allows React'suseId
hook to be used to auto-generate unique IDs.label
s withinput
s in more cases. This causes screen readers to announce the label associated with an entry when focusing it. (In 5e94b46).input
s usingaria-describedby
. (In 5e94b46).aria-expanded
information to the "Show Advanced Settings" button. This causes a screen reader to announce whether advanced settings is expanded or collapsed 1) after clicking the button and 2) when navigating to the button. (Commit aabe55a).This pull request is related to #10795.
Possible future work
landmark
(navigation
?) for easier access when using a screen reader.landmark
for easier access when using a screen reader.Testing plan
MacOS:
Show sort order buttons, checked, checkbox
before unchecking,Show sort order buttons, unchecked, checkbox
after unchecking.