Desktop: Fixes #10815: Fix Enter key submits dialogs even if a button has focus #10814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes several issues with the same underlying cause:
This commit causes Enter to only submit a dialog if the "OK" button or an input has focus. This does not affect how the Escape key is handled.
Fixes #10815.
Notes
input
or the "OK" button has the default focus. As such, in these cases, pressing Enter with the default item focused still submits the dialog.Testing plan
Manual testing (MacOS):