Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix prompt tag dialog input can be wider than its container #10818

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Aug 2, 2024

Summary

This pull request fixes a recent regression. The regression was likely introduced by 596bcd8d8b0aff25f504050053c912dba94d929c.

At certain zoom levels and on very large screens, the tag input could be wider than its containing dialog.

Testing plan

  1. Open a note.
  2. Open the "Add tag" dialog.
  3. Zoom as far out as possible.
  4. Verify that the tag selection input still fits within the dialog.
  5. Under file > switch profile, click "Create new profile...".
  6. Zoom in as far as possible.
  7. Verify that the input fits within the dialog at all zoom levels.

This has been tested successfully on MacOS.

At certain zoom levels, the tag input could be wider than its
containing dialog. This is a recent regression.
@laurent22 laurent22 merged commit 88cf1d6 into laurent22:dev Aug 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants