Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10828: Fix error when canceling bulk PDF export #10839

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes #10828bridge().showOpenDialog() returns string|string[]. When no output paths were selected, it returned an empty array ([]).

Existing code assumed that bridge().showOpenDialog() always returns a string.

Testing plan

  1. Select two notes.
  2. Click "Export" > "PDF".
  3. Click "Cancel".
  4. Verify that no error dialog is shown.
  5. Select the same two notes.
  6. Click "Export", then "PDF".
  7. Select an empty output directory.
  8. Click "Open".
  9. Verify that the directory now contains two PDF files.

This has been tested successfully on Ubuntu 24.04.

@laurent22 laurent22 merged commit 0caeced into laurent22:dev Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux: Bulk Export PDF Dialog Without Permissions
2 participants