Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seamless-Updates: implemented flow for prereleases #10892

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

AliceHincu
Copy link
Contributor

In this PR I have added the flow for prereleases.

cspell.json Outdated
Comment on lines 4 to 6
"words": [
"rcompare"
],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new words please add them to dictionary4.txt. Other than that I think the PR looks good

@laurent22
Copy link
Owner

laurent22 commented Aug 18, 2024

Just one thing actually: please keep in mind that we need tests for some of this code. We know integration with electron-updater can't really be tested, but for example the business logic to decide what version should be downloaded should be part of tests.

It might mean you'll need to refactor the code so that you can more easily test specific functions. Have a look how it's done for example in checkForUpdatesUtils.test.ts

In fact you should probably check that your code still passes the same tests as checkForUpdatesUtils.test.ts to ensure there is no regression. See how there are special cases for DMG/dmg for example, or handling of arm64/intel versions.

Maybe if you could directly use the code from checkForUpdatesUtils you would save yourself some troubles.

@laurent22
Copy link
Owner

@AliceHincu, please remember to address this comment: #10892 (comment)

@laurent22 laurent22 merged commit 2afc2ca into laurent22:dev Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants