Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix viewer and panel plugins that check for the presence of exports fail to load #10900

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This reverts commit c197a83. See this issue report on the forum.

The Function Plot plugin (and possibly other plugins) check whether a variable called exports exists to determine whether running in a NodeJS or browser environment, then export content accordingly.

c197a83 had the effect of fixing a nonfatal error in plugins that use the default plugin template. An alternate approach could be to modify the default plugin template to target web instead of node for panel/dialog/viewer scripts. See the forum post for more details.

Testing plan

  1. Install "Function Plot" plugin.
  2. Create a new note with the function plot example note content.
  3. Verify that plotted functions render in the viewer.

@laurent22 laurent22 merged commit beff45e into laurent22:dev Aug 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants