Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Add left/right arrow keys as expand/collapse shortcuts for notebooks #10944

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Aug 30, 2024

Summary

ArrowLeft and ArrowRight are listed as standard shortcuts in the ARIA Authoring Practices Guide. This pull request adds them as shortcuts to expand/collapse notebooks.

This was also requested on the forum and is related to #10795.

Testing plan

  1. Click on the entry in the notebook list for a nested notebook and expand it.
  2. Press ArrowLeft. Verify that the notebook becomes collapsed.
  3. Press ArrowRight. Verify that the notebook becomes expanded.
  4. Press ArrowRight again. Verify that the notebook remains expanded.
  5. Press ArrowLeft twice. Verify that the notebook becomes collapsed and remains so.
  6. Press Space. Verify that the notebook expands.

This has been tested successfully on Fedora 40 (Linux).

@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms accessibility Related to accessibility labels Aug 30, 2024
@laurent22 laurent22 merged commit 4f2d0c8 into laurent22:dev Aug 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants