-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to electron 18 #6496
update to electron 18 #6496
Conversation
What? You jumped from v14 to v18 and there's no other changes than on package.json?? What are the breaking changes in these 4 intermediate versions? |
electron 15 already used to be used here, so I didn't look at that, but according to https://www.electronjs.org/de/blog/electron-15-0 no APIs were removed, only features added, nativeWindowOpen is not even used by Joplin |
That's the error from the ubuntu serverdockerimage CI |
I mean it's great if it's so easy to upgrade but I find it hard to believe. If you check other Electron upgrades there are always many bugs to fix, libraries and build commands to tweak. Are you able to check the app in detail including things like printing, export, file attachment, plugins, and any system integration point? Also it seems to build on CI, but does it start? Are you able to build it as AppImage and see if it runs? |
I was astonished too but everything seemed to work. I didn't try those detailed things you listed, but I'll do that then. |
So, to the details, I tested it all with the built appimage from joplin on an arch linux with latest updates:
PluginsWith simple backup I got the error:
as a popup and:
in the console which seems to be a downstream issue but could probably be caused by an update to something (maybe something that got updated just by my Conflict resolution worked fine without error. |
Thanks for testing all this, much appreciated. It looks like we merge then. |
@alexmo1997, could I ask you to try to update electron to 18.2? |
Oops, sorry. Somehow I’ve missed «.2» after 18. But for now bug with alt-shift is still there. |
Interestingly enough, the bug does seem gone under Windows. Testing with https://github.com/laurent22/joplin/releases/tag/v2.10.2, and I can finally press |
Yep, it is a linux-specific bug. I’m using Joplin on both platforms (both with LAlt-Shift layout switching) and it works smooth under Windows. There is a similar bug in VS Code (see #4999 for details), but there are workaround with custom menubar. |
Fixes #6495
Tested on arch linux