Mobile: Fixes #6682: Disable KeyboardAvoidingView when floating keyboard is visible

[personalizedrefrigerator]

Summary

• Applies a version of the change suggested by the upstream bug report.
• Should fix [iOS] App must be restarted after each note edit #6682.
  • This seems to fix both the collapse-on-crossfade-transition issue and the collapse-with-floating-keyboard issue. The crossfade-related issue was fixed by upgrading to React Native 0.70.x.

Testing plan

1. If on an iPad, enable the floating keyboard.
2. Open the note search view and search for a note (using software keyboard).
3. Edit a note (using software keyboard)
4. Hide the software keyboard.
5. Repeat steps 1-4 with floating keyboard disabled.

To-do

• Test on Android to ensure this doesn't break anything

[laurent22]

Maybe we should just upgrade RN?

[personalizedrefrigerator]

Maybe we should just upgrade RN?

That's definitely worth trying. The fix in React Native 0.70.x is conditioned on prefersCrossFadeTransitions() returning true, however. Thus, it's unclear whether upgrading will also fix the floating keyboard issue:

facebook/react-native@4b9382c#diff-faf166615ccb0139ebe90f2db2de3e248abf7c11c8581e7223db69658cf5f87dR88

Edit: The upstream floating keyboard issue is still open.

[laurent22]

Are you able to replicate this bug on simulator? I've just upgrade to RN 0.70 so it might be worth checking if you know how.

Otherwise we can indeed add the patch, but it seems to have a dependency to a specific RN version? (0.68.5)

[personalizedrefrigerator]

Are you able to replicate this bug on simulator? I've just upgrade to RN 0.70 so it might be worth checking if you know how.

Otherwise we can indeed add the patch, but it seems to have a dependency to a specific RN version? (0.68.5)

With RN 0.70, I can't replicate the crossfade-transition-related bug, but can still replicate the floating keyboard bug. I've updated the PR to apply the fix recommended in the comments of the bug report for the floating-keyboard-related issue.

[laurent22]

Looks good, thanks for fixing this!