Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 50 - User defined exit codes #278

Merged
merged 2 commits into from
Feb 18, 2015
Merged

Issue 50 - User defined exit codes #278

merged 2 commits into from
Feb 18, 2015

Conversation

abozhilov
Copy link
Contributor

Checkout tests https://github.com/abozhilov/slimerjs-exit

For the Windows .bat file I'm not sure how to implement exit status. Don't know if it even supported.

@abozhilov abozhilov changed the title Issue 50 Issue 50 - User defined exit codes Dec 4, 2014
@@ -177,7 +177,11 @@ else
"$SLIMERJSLAUNCHER" -app "$SLIMERDIR/application.ini" $PROFILE -no-remote "$@"
fi

EXITCODE=$?
EXITCODE=0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this, we will not know when there is a problem with Gecko. I think it is better to keep the "official" exit status code, and read the exitstatus file only if EXITCODE is 0.

@laurentj
Copy link
Owner

We should suppress the exitstatus file before launching slimerjs, else at the end we will read the status code of a previous launch in the case where the same profile is used, and there is no exit() call or there is a crash...

laurentj added a commit that referenced this pull request Feb 18, 2015
Issue 50 - User defined exit codes
@laurentj laurentj merged commit f8353f8 into laurentj:master Feb 18, 2015
laurentj added a commit that referenced this pull request Feb 18, 2015
@masi
Copy link

masi commented Apr 12, 2015

In a batch file use EXIT /B [code].

@bensu
Copy link

bensu commented Oct 9, 2015

I'm wondering if this PR made it into the latest release. Looking at the source for 0.9.6 it doesn't look like it did, even though the merge data < release date by a couple of months.

@laurentj
Copy link
Owner

@bensu no, only in the master branch

@bensu
Copy link

bensu commented Oct 12, 2015

Thanks @laurentj ! I'll wait for the next release then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants