-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 50 - User defined exit codes #278
Conversation
@@ -177,7 +177,11 @@ else | |||
"$SLIMERJSLAUNCHER" -app "$SLIMERDIR/application.ini" $PROFILE -no-remote "$@" | |||
fi | |||
|
|||
EXITCODE=$? | |||
EXITCODE=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By doing this, we will not know when there is a problem with Gecko. I think it is better to keep the "official" exit status code, and read the exitstatus file only if EXITCODE is 0.
We should suppress the exitstatus file before launching slimerjs, else at the end we will read the status code of a previous launch in the case where the same profile is used, and there is no exit() call or there is a crash... |
Issue 50 - User defined exit codes
In a batch file use |
I'm wondering if this PR made it into the latest release. Looking at the source for |
@bensu no, only in the master branch |
Thanks @laurentj ! I'll wait for the next release then. |
Checkout tests https://github.com/abozhilov/slimerjs-exit
For the Windows .bat file I'm not sure how to implement exit status. Don't know if it even supported.