Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are missing from the popup window #383

Closed
javier-goma opened this issue Mar 18, 2021 · 11 comments · Fixed by #440
Closed

Icons are missing from the popup window #383

javier-goma opened this issue Mar 18, 2021 · 11 comments · Fixed by #440
Labels

Comments

@javier-goma
Copy link

javier-goma commented Mar 18, 2021

Versions

  • Git Diff Margin version: 3.10.3.462
  • Visual Studio version: Community 2019 - Version 16.7.3

What happened

After a change, I wanted to see what was different from the previous commit and I realized that the icons were missing.
I thought it was a theme problem because I use a custom one but even with the VS standard one I see the same problem

Steps to Reproduce

Steps to reproduce the behavior:

  1. Do any change so that the diff margin can appear
  2. Click on the margin so that the popup menu is visible
  3. The icons are missing

Expected behavior

The popup menu should be showing the icons

Screenshots

image

Additional context

I have tried many things to fix it but not sure what can be, I hope wen can find the solution

Thanks in advance, it's a really great extension

@laurentkempe
Copy link
Owner

Thanks for @javier-goma for taking the time to report this.
I had a quick look with VS 20219 Pro - Version 16.9.1

image

My guess is that it comes from ressources embedding, but I need to investigate.

@javier-goma
Copy link
Author

Hi @laurentkempe,

I just updated Visual Studio 2019 Community to version 16.9.2 and the icons are being shown

In case you agree, the bug can be closed

Thanks

@laurentkempe
Copy link
Owner

Thanks @javier-goma

@Otiel
Copy link

Otiel commented Jul 8, 2021

After installing GitDiffMargin 3.11.5, I have the same issue using VS 2019 Professional 16.10.3.

@cnotin
Copy link

cnotin commented Jul 8, 2021

I had the same problem with the same versions (GitDiffMargin 3.11.5 and VS 2019 Professional 16.10.3)
It fixed itself after disabling the extension, restarting VS, enabling, restart :)

@Otiel
Copy link

Otiel commented Jul 8, 2021

disabling the extension, restarting VS, enabling, restart

That fixed it for me as well, thanks for the tip @cnotin

@toughengineer
Copy link

Turning off and on again helped me as well.
All hail the sacred ritual!

@m2nlight
Copy link

m2nlight commented Jul 16, 2021

I tryed to reactive gitmargindiff, then the icons are backed.
But, if run two vs2019(16.10.3) instances, the icons are gone in second instance.

@laurentkempe
Copy link
Owner

This is something we will need to have a look into!

@sharwell
Copy link
Collaborator

Agree. I'll see what I can find out

@laurentkempe
Copy link
Owner

I will try to have a look next week after vacations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants