Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in vector simplification #249

Closed
laurentlb opened this issue Mar 18, 2023 · 0 comments · Fixed by #251
Closed

bug in vector simplification #249

laurentlb opened this issue Mar 18, 2023 · 0 comments · Fixed by #251

Comments

@laurentlb
Copy link
Owner

Apparently, this is allowed:

vec3 v3 = vec3(1);
vec4 v4 = vec4(v3, v3);

and should be equivalent to v3.xyzx, but Minifier returns vec4(v3) which doesn't compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply vector simplification only when the number of arguments matches laurentlb/shader-minifier
1 participant
@laurentlb