Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect more augmentable operators #369

Merged
merged 1 commit into from
May 4, 2024
Merged

Detect more augmentable operators #369

merged 1 commit into from
May 4, 2024

Conversation

laurentlb
Copy link
Owner

a=3+a => a+=3

@laurentlb laurentlb merged commit 343efc4 into master May 4, 2024
1 check passed
@laurentlb laurentlb deleted the norm branch May 4, 2024 21:04
@therontarigo
Copy link
Contributor

therontarigo commented May 5, 2024

This is broken for noncommutative operations:
Consider the case of matrix-vector multiplication:

mat3 M;
vec3 v;
v = M*v;

v*=M performs v = v*M, so it is not a correct transformation.

Indeed, it is broken in several of the tests and furthermore the tests have been overwritten with broken results:
343efc4#r141691262

laurentlb added a commit that referenced this pull request May 5, 2024
laurentlb added a commit that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants