Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parentheses when the comma operator is in a function call #57

Merged
merged 1 commit into from
May 9, 2021

Conversation

laurentlb
Copy link
Owner

In min((a=1.0,b+a), 0.0), Shader Minifier didn't preserve the parentheses.

Fixes #20
Thanks to dabadab

In `min((a=1.0,b+a), 0.0)`, Shader Minifier didn't preserve the parentheses.

Fixes #20
Thanks to dabadab
Copy link
Collaborator

@eldritchconundrum eldritchconundrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no function_comma.frag.expected file?

@laurentlb laurentlb merged commit 6abc9f5 into master May 9, 2021
@laurentlb
Copy link
Owner Author

Added test in 8efc4fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comma operators unparenthesed in function calls
2 participants