Fix return value when tre_parse() hits the stack limit
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dag-erling
changed the title
tre_parse() hits the stack limit
dag-erling
force-pushed
the
des/toolong
branch
2 times, most recently
from
a68835d to
772406a
Compare
This adds a test case consisting of 2,048 left parens followed by 2,048 right parens. It is syntactically correct and properly balanced but overflows the stack, so it should return REG_ESPACE, but instead it returnd REG_EPAREN.
* Remove redundant status check at the top of the loop. It's already part of the loop condition. * Check status immediately after the loop terminates, so if we hit the stack limit, we correctly return REG_ESPACE, not REG_EPAREN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.