Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to deep_merge 1.0.1 #12

Closed
jnankin opened this issue Jan 20, 2016 · 2 comments
Closed

update to deep_merge 1.0.1 #12

jnankin opened this issue Jan 20, 2016 · 2 comments

Comments

@jnankin
Copy link

jnankin commented Jan 20, 2016

My app requires deep_merge 1.0.1 to avoid deprecation warnings such as "warning: Return nil in #<=> if the comparison is inappropriate or avoid such comparison."

Can we update the dependency version for s3_website?
@laurilehmijoki
Copy link
Owner

Hello! Can you send a pull request and test the tool with the updated deep_merge lib?

@jnankin
Copy link
Author

jnankin commented Jan 20, 2016

Issued a PR

laurilehmijoki added a commit that referenced this issue Jan 22, 2016
@laurilehmijoki
Merge pull request #13 from jnankin/master
a371c85 
fixes #12 allow minor versions of deep_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnankin @laurilehmijoki