Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari web extension #21

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Safari web extension #21

wants to merge 4 commits into from

Conversation

lautis
Copy link
Owner

@lautis lautis commented Oct 17, 2020

Migrate the project to use Safari Web Extensions. This PR mostly works, but code signing does not: the built app requires "Allow unsigned extensions" to be enabled. Also currently the extension must be manually enabled also on github.com, but it probably should ask for permission.

Preview build

fixes #5, fixes #6, fixes #7, fixes #8.

@lautis lautis marked this pull request as draft October 17, 2020 18:25
@fregante
Copy link
Contributor

the built app requires "Allow unsigned extensions" to be enabled

From my understanding, this is because Apple decided that Safari extensions can only be distributed via the App store. Another example: npmhub/npmhub#113 (comment)

@fregante
Copy link
Contributor

currently the extension must be manually enabled also on github.com

It appears that this is also required since, unlike other extension stores, the App Store never asks for permission before installing. Therefore the user is always required to grant access after install.

Some extensions work around this requirements:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants