Skip to content

Commit

Permalink
Fix CI runs by disabling flaky test class.
Browse files Browse the repository at this point in the history
  • Loading branch information
lauxjpn committed Dec 11, 2024
1 parent 1c7f31e commit 183ad09
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected override TestModelBuilder CreateModelBuilder(
=> new ModelBuilderTest.GenericTestModelBuilder(Fixture, configure);
}

public class MySqlGenericOwnedTypes(MySqlModelBuilderFixture fixture) : MySqlOwnedTypes(fixture)
internal class MySqlGenericOwnedTypes(MySqlModelBuilderFixture fixture) : MySqlOwnedTypes(fixture)
{
// MySQL stored procedures do not support result columns.
public override void Can_use_sproc_mapping_with_owned_reference()
Expand Down
17 changes: 17 additions & 0 deletions test/EFCore.MySql.FunctionalTests/MySqlComplianceTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Reflection;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.ModelBuilding;
using Microsoft.EntityFrameworkCore.Query;
using Microsoft.EntityFrameworkCore.Update;

Expand All @@ -12,6 +13,22 @@ public class MySqlComplianceTest : RelationalComplianceTestBase
// TODO: Implement remaining 3.x tests.
protected override ICollection<Type> IgnoredTestBases { get; } = new HashSet<Type>
{
// There are two classes that can lead to a MySqlEndOfStreamException, if *both* test classes are included in the run:
// - RelationalModelBuilderTest.RelationalComplexTypeTestBase
// - RelationalModelBuilderTest.RelationalOwnedTypesTestBase
//
// The exception is thrown for MySQL most of the time, though in rare cases also for MariaDB.
// We disable `RelationalModelBuilderTest.RelationalOwnedTypesTestBase` for now.

// typeof(RelationalModelBuilderTest.RelationalNonRelationshipTestBase),
// typeof(RelationalModelBuilderTest.RelationalComplexTypeTestBase),
// typeof(RelationalModelBuilderTest.RelationalInheritanceTestBase),
// typeof(RelationalModelBuilderTest.RelationalOneToManyTestBase),
// typeof(RelationalModelBuilderTest.RelationalManyToOneTestBase),
// typeof(RelationalModelBuilderTest.RelationalOneToOneTestBase),
// typeof(RelationalModelBuilderTest.RelationalManyToManyTestBase),
typeof(RelationalModelBuilderTest.RelationalOwnedTypesTestBase),

typeof(UdfDbFunctionTestBase<>),
typeof(TransactionInterceptionTestBase),
typeof(CommandInterceptionTestBase),
Expand Down

0 comments on commit 183ad09

Please sign in to comment.