Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for new PIPG-based QP solver in Lava #105

Merged
merged 31 commits into from
Oct 27, 2022
Merged

Adding support for new PIPG-based QP solver in Lava #105

merged 31 commits into from
Oct 27, 2022

Conversation

ashishrao7
Copy link
Collaborator

Issue Number: #104

Objective of pull request: Adding support for new PIPG-based QP solver in Lava

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally
    Tests in main that do not correspond to the tests in this PR fail

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

  • Added processes for new qp solver
  • Added floating point model of new qp solver
  • Refactored redundant connection processes to one local connection process required for the solver

Process interfaces here are also used for the hardware QP solver.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

ashishrao7 and others added 30 commits November 15, 2021 19:16
@ashishrao7
Fixed image in tutorials, corrected README and deleted examples folder
1284a52
@ashishrao7
cosmetic changes to README
af09b3c
@ashishrao7
moved tutorials inside src
7e808d3
@ashishrao7
Merge branch 'lava-nc:main' into main
643aac2
@ashishrao7
corrected LAVA typo, removed stuff in solver.py
c3c94d1
@ashishrao7
corrected typos in QP tutorial
e70adc6
@ashishrao7
corrected typos in QP tutorial
1ffa126
@ashishrao7
Added more information, Corrected a mistake in formula
774f114
@ashishrao7
Made changes to models.py to make interface consistent. Corresponding…
2f04430 
… changes to tests. Removed hardcoded preconditioning from solver.py
@ashishrao7
Making changes to tutorials, refining for LDF. Halfway through
1c5db89
@ashishrao7
Updated Notebook tutorial. Need to replace and add images
4a32a37
@ashishrao7
Deleted outprobe process from tutorial. Added MPC example
6e285ca
@ashishrao7
Ran MPC example, TODo: add image for applications in the notebook
e10da80
@ashishrao7
Fixed Broken links, added Image to tutorial
dfe8153
@mgkwill
Pull latest lava-nc/lava
f8268e9
@mgkwill
Update build.py
e0d6332
@mgkwill
Create __init__.py in tests ... qp
f03fd67
@mgkwill
Update __init__.py
4e7e87a
@mgkwill
Update __init__.py
e8d2249
@mgkwill
Fix init issues
c499d87 
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
@ashishrao7
Added new MPC image to tutorials
20d8407
@ashishrao7
Merge branch 'main' of https://github.com/ashishrao7/lava-optimization
74187da
@ashishrao7
Changed new MPC image to tutorials
a63aea5
@ashishrao7
Merge branch 'lava-nc:main' into main
ce84a97
@ashishrao7
Moved tutorials to root and fixed broken links
dfdc257
@ashishrao7
Tutorial link in README fixed
4fa5d1f
@ashishrao7
Merge branch 'lava-nc:main' into main
3437b4f
@ashishrao7
Merge branch 'lava-nc:main' into main
a44fdc8
@ashishrao7
Merge branch 'lava-nc:main' into main
106f2f3
@ashishrao7
Following additions in this commit:
4aba939 
1. Added new pipg solver process interface and process models
(updated tests)
2. Refactored older local connectivity processes for solver into
one local connectivity process
3. Updated license information in all files

Linted with black -l 79
@ashishrao7 ashishrao7 added the 1-feature New feature or request label Oct 27, 2022
@ashishrao7 ashishrao7 self-assigned this Oct 27, 2022
GaboFGuerra
GaboFGuerra approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashish, great job!
A few methods are too long indicating they do more than one thing and method extraction can be performed. Otherwise, nice implementation.

@GaboFGuerra GaboFGuerra merged commit 80929f0 into lava-nc:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

@mgkwill mgkwill Awaiting requested review from mgkwill

@srrisbud srrisbud Awaiting requested review from srrisbud

@phstratmann phstratmann Awaiting requested review from phstratmann

Assignees

@ashishrao7 ashishrao7

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashishrao7 @GaboFGuerra @mgkwill