Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable different graph structures in MISProblem generator #224

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Enable different graph structures in MISProblem generator #224

merged 14 commits into from
Jan 29, 2024

Conversation

AlessandroPierro
Copy link
Collaborator

@AlessandroPierro AlessandroPierro commented May 17, 2023 •
edited
Loading

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

  • Feature

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes

@AlessandroPierro AlessandroPierro marked this pull request as ready for review May 17, 2023 09:22
@AlessandroPierro AlessandroPierro self-assigned this May 17, 2023
@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label May 17, 2023
GaboFGuerra
GaboFGuerra previously requested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alessandro! This is a beautiful and valuable refactoring.

src/lava/lib/optimization/utils/generators/mis.py Outdated Show resolved Hide resolved
src/lava/lib/optimization/utils/generators/mis.py Outdated Show resolved Hide resolved
src/lava/lib/optimization/utils/generators/mis.py Outdated Show resolved Hide resolved
src/lava/lib/optimization/utils/generators/mis.py Outdated Show resolved Hide resolved
src/lava/lib/optimization/utils/generators/mis.py Outdated Show resolved Hide resolved
tests/lava/lib/optimization/utils/generators/test_mis.py Outdated Show resolved Hide resolved
@AlessandroPierro AlessandroPierro requested review from GaboFGuerra and removed request for GaboFGuerra and phstratmann July 27, 2023 17:06
phstratmann
phstratmann approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, good work! Just a few comments. Feel free to merge once incorporated (or if you dislike my comments).

@AlessandroPierro AlessandroPierro removed the request for review from GaboFGuerra January 29, 2024 17:01
@AlessandroPierro AlessandroPierro merged commit 1d792a6 into main Jan 29, 2024
4 checks passed
@AlessandroPierro AlessandroPierro deleted the mis-graphs branch January 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phstratmann phstratmann phstratmann approved these changes

@GaboFGuerra GaboFGuerra GaboFGuerra left review comments

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlessandroPierro @GaboFGuerra @phstratmann