V0.1.0 of Lava-optimization #7

ashishrao7 · 2021-11-10T10:35:05Z

This pull request is v0.1.0 of the lava-optimization library. It references issues #2 and #3 . It contains the first version of the QP solver and a tutorial for using QP solvers to implement LASSO.
Reviewers: @GaboFGuerra @awintel and Sumedh

… the solution neurons process

Signed-off-by: gguerra <gabriel.guerra@intel.com>

… Need to test them with the developing solver interface

QP process and models (without tests )

….py for qp solver

… except constraintcheck and gradient dynamics

… except GradientDynamics

…d Initialization tests to test_process.py and behavioral tests to test_models.py

…king

… level in models.py. Pending GradientDynamics behavioral test

…tion into v0.1.0

…correctness of solution

…tutorial notebook

ashishrao7 · 2021-11-12T14:03:57Z

Great! I already approved but now there is one last thing...

You argued before that the users of the library would be intimately familiar with the member names Q, p, etc. and that it would not be helpful to rename them to more descriptive names. The @property methods for those members have descriptive names now (get_hessian() returns self._Q). I suggest sticking either with the math-inspired or the descriptive names throughout to be consistent.

I changed this to be more consistent like you suggested. Matched it to the interface.

Apart from that everything looks good.

Also added typing now

Done in commit 7313974

mgkwill

Looks good to me (LGTM).

setup.py is auto generated, but formatting it is fine.

For consistency sake:
src/lava/lib/optimization/init.py does not have copyright header.
src/lava/lib/optimization/solvers/init.py does not have copyright header.

I don't think we should have src/init.py, but we can test without and fix later

After our conversation we should follow lowercase var names in src/lava/lib

….lib

…tion into v0.1.0

ashishrao7 · 2021-11-12T21:09:38Z

Looks good to me (LGTM).

setup.py is auto generated, but formatting it is fine.

For consistency sake: src/lava/lib/optimization/init.py does not have copyright header. src/lava/lib/optimization/solvers/init.py does not have copyright header.

I don't think we should have src/init.py, but we can test without and fix later

After our conversation we should follow lowercase var names in src/lava/lib

Resolved all comment in commit b09944e

phstratmann

My comments were all handled well and resolved, thanks Ashish!

Please note: Due to time restrictions, I only covered ~50% of the code and not to full depth.

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

GaboFGuerra

Looks good!

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

mgkwill · 2021-11-13T05:05:08Z

Only failure in CI is because of long path on windows. False positive. Merging.

GaboFGuerra and others added 30 commits November 3, 2021 16:11

Add folder and file structure for optimization library.

cf0a40f

adding core processes and models of QP solver (without tests)

81abab7

removed separate process for learning constants and added them inside…

2e22060

… the solution neurons process

Flatten out lava from tests path.

b964ff1

Signed-off-by: gguerra <gabriel.guerra@intel.com>

completed constraintCheck and GradientDynamics Heirarchial processes.…

6594e3c

… Need to test them with the developing solver interface

corrected class names to camel case

171dd4c

Merge pull request #1 from GaboFGuerra/qp

3c1ea0e

QP process and models (without tests )

renamed folders under solver in test and lava optimization

ec8e31a

adding __init__.py file for module level imports

6688610

adding test where process doesn't run yet

5c59ab3

processes not running but corrected some imports

a8684b4

added init tests for process and made change to import path in models…

08e85b8

….py for qp solver

initialization tests for all processes passing. Behavioral tests pending

a54c5ac

fixed typo in docstring

985d378

fixed very important code-breaking error (class naming) in models.py

74605c2

fixed naming conflicts in qp models, tests behaviors of all procceses…

5bc75be

… except constraintcheck and gradient dynamics

Fixed logical errors in process and models. Passing all process tests…

bbc5bdf

… except GradientDynamics

All processes excepted GradientDynamics Behaviorally tested. Separate…

2bcc3cb

…d Initialization tests to test_process.py and behavioral tests to test_models.py

added __init__.py files and changed gitignore to include \lib in trac…

1a93c68

…king

Added docstrings for model tests. Moved docstrings from init to class…

1f0fa37

… level in models.py. Pending GradientDynamics behavioral test

remove modules not part of first mini-release branch.

68d1548

Merge branch 'lava-nc:main' into v0.0.1

91bba57

Re-organize repo structure according to CI changes on main repo.

fba2e8b

Move tests to right folder.

0692d44

Add missing init files and update README.md.

abba0f2

All process and model tests passing. Final QP solver under construction

8ce1aa6

Merge branch 'v0.1.0' of https://github.com/GaboFGuerra/lava-optimiza…

5f640cc

…tion into v0.1.0

QP solver dynamics work! Need to tune constants for problem and test …

b7c7598

…correctness of solution

Fixed logical error for solution neurons

2b95f0a

Added Interface for QP solver in tests. Solver not yet converging

b2cc290

Added typing. Resolved feedback from Mathis. Made corrections to the …

7313974

…tutorial notebook

ashishrao7 added 2 commits November 12, 2021 15:06

removed unused import to fix CI/CD

5e273de

Removed pause and flush functions. Passing CI/CD tests.

bf7dbfd

mgkwill previously approved these changes Nov 12, 2021

View reviewed changes

Update ci-build.yml

5257922

mgkwill dismissed their stale review via 5257922 November 12, 2021 19:58

mgkwill and others added 6 commits November 12, 2021 12:10

Add numpy to requirements.txt

52d4de8

Pull lava-nc-0.1.0.tar.gz, install for CI run

7284be7

changed variable names from Upper case to descriptive lower case

396325c

CI Change version of lava from 0.1.0 to 0.1.1

7bc15f2

removed __init__.py from src folder. fixed all paths to point to lava…

34dbd32

….lib

Merge branch 'v0.1.0' of https://github.com/GaboFGuerra/lava-optimiza…

1c05b11

…tion into v0.1.0

ashishrao7 requested a review from phstratmann November 12, 2021 20:53

added copyright to init files. Corrected documentation in problems.py

b09944e

phstratmann approved these changes Nov 12, 2021

View reviewed changes

GaboFGuerra and others added 6 commits November 12, 2021 23:41

Add QP example and emphasize order of PYTHONPATH.

cebbfc1

Correct tutorial name.

51ef005

Update lava installation link + improve language.

5a3be90

Fix build, depend on lava release tar

d0c3381

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

Remove wget lava tar from CI

2dbc6e2

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

Add link to QP solver tutorial.

0242802

mathisrichter approved these changes Nov 12, 2021

View reviewed changes

GaboFGuerra approved these changes Nov 13, 2021

View reviewed changes

Update req.txt w/ lava-nc version

6e0bca2

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

mgkwill approved these changes Nov 13, 2021

View reviewed changes

mgkwill merged commit c1c197f into lava-nc:main Nov 13, 2021

GaboFGuerra deleted the v0.1.0 branch January 21, 2022 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V0.1.0 of Lava-optimization #7

V0.1.0 of Lava-optimization #7

ashishrao7 commented Nov 10, 2021 •

edited

Loading

ashishrao7 commented Nov 12, 2021 •

edited

Loading

mgkwill left a comment •

edited

Loading

ashishrao7 commented Nov 12, 2021

phstratmann left a comment

GaboFGuerra left a comment

mgkwill commented Nov 13, 2021

V0.1.0 of Lava-optimization #7

V0.1.0 of Lava-optimization #7

Conversation

ashishrao7 commented Nov 10, 2021 • edited Loading

ashishrao7 commented Nov 12, 2021 • edited Loading

mgkwill left a comment • edited Loading

Choose a reason for hiding this comment

ashishrao7 commented Nov 12, 2021

phstratmann left a comment

Choose a reason for hiding this comment

GaboFGuerra left a comment

Choose a reason for hiding this comment

mgkwill commented Nov 13, 2021

ashishrao7 commented Nov 10, 2021 •

edited

Loading

ashishrao7 commented Nov 12, 2021 •

edited

Loading

mgkwill left a comment •

edited

Loading