Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Process Model Search to Allow Relative Imports #903

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kds300
Copy link
Contributor

@kds300 kds300 commented Dec 19, 2024

Issue Number: #902

Objective of pull request: Modify process model search process to allow for relative imports when defining custom processes and process models.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
    • Changed code does not raise issues.
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Relative imports break process model search.

What is the new behavior?

  • Relative imports can now be used in defining process models.

Does this introduce a breaking change?

  • Yes
  • No

… relative imports

Signed-off-by: kevin <kds300@psu.edu>
Signed-off-by: kevin <kds300@psu.edu>
… skipped

Signed-off-by: kevin <kds300@psu.edu>
Signed-off-by: kevin <kds300@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant