Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding provider optimizer tiers #1679

Merged
merged 32 commits into from
Sep 15, 2024
Merged

feat: adding provider optimizer tiers #1679

merged 32 commits into from
Sep 15, 2024

Conversation

omerlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Sep 8, 2024

Test Results

2 205 tests  +32   2 205 ✅ +32   24m 14s ⏱️ - 2m 0s
  145 suites ± 0       0 💤 ± 0 
    7 files   ± 0       0 ❌ ± 0 

Results for commit e3e9c78. ± Comparison against base commit aae38b9.

This pull request removes 3 and adds 35 tests. Note that renamed tests count towards both.
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestPerturbation
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerPerturbation
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerStrategiesProviderCount
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestNewSelectionWeighter
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerExploration
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/eight
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/five
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/four
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/nine
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/one
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/seven
github.com/lavanet/lava/v3/protocol/provideroptimizer ‑ TestProviderOptimizerProvidersCount/six
…

♻️ This comment has been updated with latest results.

@ranlavanet ranlavanet self-requested a review September 9, 2024 07:50
protocol/lavasession/consumer_types.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 9, 2024
@omerlavanet omerlavanet marked this pull request as ready for review September 11, 2024 12:58
@omerlavanet omerlavanet merged commit f7c62a0 into main Sep 15, 2024
31 checks passed
@omerlavanet omerlavanet deleted the add-optimizer-tiers branch September 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants