Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GRPC health #1690

Merged
merged 11 commits into from
Sep 12, 2024
Merged

feat: GRPC health #1690

merged 11 commits into from
Sep 12, 2024

Conversation

amitza
Copy link
Collaborator

@amitza amitza commented Sep 11, 2024

Description

Closes: #154

Add support for GRPC health checking. This will allow the blackbox exporter to query the GRPC directly.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@amitza amitza self-assigned this Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Test Results

2 173 tests  +3   2 173 ✅ +4   26m 17s ⏱️ +7s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌  - 1 

Results for commit 2e16857. ± Comparison against base commit 66aaf13.

♻️ This comment has been updated with latest results.

protocol/rpcprovider/provider_listener_test.go Outdated Show resolved Hide resolved
protocol/rpcprovider/provider_listener_test.go Outdated Show resolved Hide resolved
protocol/rpcprovider/provider_listener_test.go Outdated Show resolved Hide resolved
@shleikes shleikes self-requested a review September 12, 2024 08:48
@amitza amitza requested review from omerlavanet and removed request for nimrod-teich and ranlavanet September 12, 2024 08:50
@omerlavanet omerlavanet merged commit d0a883c into main Sep 12, 2024
31 checks passed
@omerlavanet omerlavanet deleted the feat/grpc-healthchecks branch September 12, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants