Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Workaround node-gyp issue #439

Merged
merged 2 commits into from
Jan 16, 2024
Merged

CI: Workaround node-gyp issue #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d0e21
Fix compilation
orgads Jan 16, 2024
955d2a2
CI: Workaround node-gyp issue
orgads Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ jobs:
os: [ ubuntu-latest, macos-latest, windows-latest ]
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- run: python3 -m pip install setuptools
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down Expand Up @@ -40,7 +42,7 @@ jobs:
strategy:
matrix:
node-version: [ 16, 18, 20 ]
container: node:${{ matrix.node-version }}-alpine3.18
container: node:${{ matrix.node-version }}-alpine
steps:
- uses: actions/checkout@v3
- name: install build deps
Expand Down
2 changes: 1 addition & 1 deletion src/isolate/inspector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ auto InspectorAgent::ConnectSession(InspectorSession& session) -> unique_ptr<V8I
active_sessions.write()->insert(&session);
#if V8_AT_LEAST(10, 3, 118)
return inspector->connect(1, &session, StringView(), v8_inspector::V8Inspector::ClientTrustLevel::kFullyTrusted);
#elif
#else
return inspector->connect(1, &session, StringView());
#endif
}
Expand Down
Loading