Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running on Node 20.11 #441

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix running on Node 20.11 #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/module/context_handle.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

using namespace v8;

#if !V8_AT_LEAST(10, 1, 1)
#define CompileFunction CompileFunctionInContext
#endif

namespace ivm {
namespace {

Expand Down Expand Up @@ -197,7 +201,7 @@ class EvalClosureRunner : public CodeCompilerHolder, public ThreePhaseTask {
// Invoke `new Function` to compile script
auto source = GetSource();
auto function = RunWithAnnotatedErrors([&]() {
return Unmaybe(ScriptCompiler::CompileFunctionInContext(
return Unmaybe(ScriptCompiler::CompileFunction(
context, source.get(),
argument_names.size(), argument_names.empty() ? nullptr : &argument_names[0],
0, nullptr
Expand Down
Loading