Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit 12.09 #13

Merged
merged 21 commits into from
Sep 23, 2024
Merged

fix: audit 12.09 #13

merged 21 commits into from
Sep 23, 2024

Conversation

nksazonov
Copy link
Contributor

No description provided.

@nksazonov
ref: move vault-related contracts & tests to test/vault
0020e3b
@nksazonov
fix(LiteVault): use call instead of transfer when withdrawing ETH
34af09c
@nksazonov
fix(LiteVault): pass authorizer in constructor, zero address checks f…
379f996 
…or it
@nksazonov
fix(BrokerToken): add zero address check for beneficiary in constructor
dd3f1b4
@nksazonov
feat: add IAuthorizable interface, emit AuthorizerChanged event
10172c3
@nksazonov
fix(LiteVault): checks-effects-interactions pattern
069750e
@nksazonov
nit(LiteVault): remove override modifiers
6b02a67
@nksazonov
ref: make balanceOf and deposit external`
ba2fe32
@nksazonov
fix: pin submodules to a tag
39ac5cc
@nksazonov
chore(LiteVault): use named parameters in mapping
c0b4e2c
@nksazonov
chore(TimeRangeAuthorizer): make time vars immutable
596dc6a
@nksazonov
feat: add Ownable2Step instead of Ownable
4bb9138
@nksazonov
conf: specify evm version to be cancun
0e927dc
@nksazonov
feat: withdrawal grace period after authorizer has changed
5523486
@nksazonov
chore: lock solidity version to 0.8.26
bf6d895
@nksazonov nksazonov requested a review from mod September 20, 2024 12:36
mod
mod reviewed Sep 20, 2024
View reviewed changes
src/interfaces/IVault.sol Outdated Show resolved Hide resolved
@nksazonov nksazonov requested review from mod and maxpushka September 23, 2024 08:11
maxpushka
maxpushka approved these changes Sep 23, 2024
View reviewed changes
test/BrokerToken.t.sol Outdated Show resolved Hide resolved
test/TestERC20.sol Outdated Show resolved Hide resolved
@nksazonov nksazonov merged commit 9190fd8 into master Sep 23, 2024
2 checks passed
@nksazonov nksazonov deleted the fix/audit-12-09 branch September 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpushka maxpushka maxpushka approved these changes

@mod mod Awaiting requested review from mod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nksazonov @mod @maxpushka