fix: static generated RSC x-component and response type selection #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues around static generated RSC x-component files and how response type selection works to send an RSC payload. The response type selection needs to be on par with the static generation to maintain the same solution for both static and dynamic rendering.
Changes request payload to select RSC rendering. Instead of using HTTP headers, the framework now uses an URL pathname suffix, including outlet name and remote or standard RSC rendering and static generation uses the same format in filenames. This fixes #95.
Adds build options to enable compression (GZip and Brotli) and opt-out of static RSC rendering, see more about this in the updated docs.
Adds static export option to render a single outlet. This is mainly to keep consistency with the URL format right now, but might be a useful feature for SSG.
Updates the deployment Adapter API to not copy compressed files by default, but copy static RSC files and also the Vercel adapter to add the necessary
Content-Typeheader for static.x-componentfiles. This fixes #94.Removes the
standaloneroute option and mode as it was not really useful and there are other ways to achieve the same functionality.