Add rules for substitute holidays to South Korea calendar #1707
Conversation
ql/time/calendars/southkorea.cpp
Outdated
| if ((w == Monday && (d == 2 || d == 3) && m == March && y > 2021) || | ||
| (w == Monday && (d == 6 || d == 7) && m == May && y > 2013) || | ||
| (w == Monday && (d == 16 || d == 17) && m == August && y > 2020) || | ||
| (w == Monday && (d == 4 || d == 5) && m == October && y > 2020) || | ||
| (w == Monday && (d == 10 || d == 11) && m == October && y > 2020) || | ||
| (w == Monday && (d == 26 || d == 27) && m == December && y > 2022)) { |
There was a problem hiding this comment.
I would move each of these condition a bit below, together with the original condition for the corresponding holiday.
There was a problem hiding this comment.
It looks better. thanks luigi.
There was a problem hiding this comment.
Sorry, I wasn't clear — I meant moving each substitute rule with its holiday. I pushed the change myself.
A suggestion for next time: it's better to open the PR from a branch, not master, so my pushes (if any) are less disruptive. Thanks!
|
Thanks! May you add to the documentation in the hpp file a link to your source for the information? |
|
I found a legal document about alternative public holidays in SouthKorea. Unfortunately, it is not written in English, but I will attach it to the header file. |
lballabio
changed the title
|
Your code is really awesome. Thanks for accept to 1.31 milestone. |
No description provided.