Added Warsaw Stock Exchange Calendar (Poland) #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it. |
|
|
|
Thanks! May you also check the comment from CLAassistant above? |
lballabio
reviewed
Aug 20, 2024
ql/time/calendars/poland.cpp
Outdated
| // all calendar instances share the same implementation instance | ||
| static ext::shared_ptr<Calendar::Impl> impl(new Poland::Impl); | ||
| impl_ = impl; | ||
| // static ext::shared_ptr<Calendar::Impl> impl(new Poland::Impl); |
There was a problem hiding this comment.
No need to keep the old one commented, you can remove it
There was a problem hiding this comment.
Yes, my oversight, already corrected
Thank you, done |
|
Congratulations on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Luigi, hi all,
I'm here since v1.23 and up until now I have been building my own version of library which has additional polish calendar which is in line with Warsaw Stock Exchange calendar (https://www.gpw.pl/session-details -> click tab Exchange holidays) which consists two more holidays than standard polish calendar that is: 24 December and 31 December. These are days without market session in Poland. It is not a big deal, but I thought that why not make PR in upstream repo.
I believe adding to library such WSE calendar would be small attraction for users calculating dates according to stock exchange calendar in Poland.
Instead one Poland calendar I offered two: Poland Settlement and Warsaw stock exchange. Poland Settlement would be default one to keep backward compatibility, and if one would need WSE calendar, he need to explicitly chose it.
Credits also to @adamgrad5 for coworking on this PR.
I hope you find this PR useful. If so, I'll create relevant PR to SWIG repo as well.