feat(solr): Add ability to inject options to the request #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianlam
previously requested changes
Feb 13, 2020
I have reverted all the changes to the whitespaces/formatting. |
niezgoda
requested review from
julianlam,
cliftonc,
ColadaFF,
jos3000,
lbdremy,
loveirobert,
luketaverne,
marc-portier,
motns,
nicolasembleton and
vaneetkaur
|
Is there a way to put this on some track? :) |
|
As this is an API change (introducing a new argument to the |
|
Hello, This change does not break the API, so no worries for me. You can merge @julianlam and publish a new minor version 0.8.0. |
…into feature/ssl � Conflicts: � lib/solr.js
kibertoad
dismissed
julianlam’s stale review
whitespace changes were removed
|
Released in 0.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no ability to pass additional arguments to the http/https request.
The option to add (for example) ssl parameters (like ca, cert, key) is neccesarry in multiple cases.