Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump black fmt to 22.3.0 to fix issues with click #329

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Bump black fmt to 22.3.0 to fix issues with click #329

merged 1 commit into from
Mar 28, 2022

Conversation

jccurtis
Copy link
Collaborator

@jccurtis jccurtis commented Mar 28, 2022 •
edited
Loading

See #328 for (a lot) more details

@jccurtis jccurtis added the bug label Mar 28, 2022
@jccurtis jccurtis mentioned this pull request Mar 28, 2022
Merged
@jccurtis jccurtis requested a review from micahfolsom March 28, 2022 21:38
@micahfolsom
Copy link
Collaborator

Looks good to me @jccurtis

@jccurtis
Copy link
Collaborator Author

For future reference (to our future selfs) this was related to the virtual env for pre-commit not picking up the new version of black. Running black . in the repo worked but pre-commit run --all didn't. Thanks @micahfolsom @markbandstra @jvavrek for the hacking.

@jccurtis jccurtis merged commit 93d9cc6 into main Mar 28, 2022
@jccurtis jccurtis deleted the bump-black-22.3.0 branch March 28, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbandstra markbandstra markbandstra approved these changes

@jvavrek jvavrek Awaiting requested review from jvavrek

@micahfolsom micahfolsom Awaiting requested review from micahfolsom

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jccurtis @micahfolsom @markbandstra