Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nbQA pre-commit hooks and fix issues #393

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add nbQA pre-commit hooks and fix issues #393

merged 1 commit into from
Feb 20, 2024

Conversation

markbandstra
Copy link
Member

Adds nbQA to our pre-commit suite.

@markbandstra markbandstra requested a review from jvavrek February 16, 2024 23:31
@markbandstra markbandstra self-assigned this Feb 16, 2024
jvavrek
jvavrek approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@jvavrek jvavrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook diffs are hard to read, but after a quick skim it looks like mostly whitespace, quote, and trailing zero changes (as we might expect). Approved!

@markbandstra markbandstra merged commit 38cbf5d into main Feb 20, 2024
22 checks passed
@markbandstra markbandstra deleted the pre-commit-nbqa branch February 20, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvavrek jvavrek jvavrek approved these changes

Assignees

@markbandstra markbandstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markbandstra @jvavrek