Retry on EADDRINUSE. #102
Merged
Retry on EADDRINUSE. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackrobison
approved these changes
Sep 26, 2022
| started = True | ||
| except OSError as e: | ||
| if e.errno is errno.EADDRINUSE: | ||
| await asyncio.sleep(3) |
There was a problem hiding this comment.
Can this log as a warning? Otherwise LGTM
There was a problem hiding this comment.
Are there other socket errors we might get? Is this needed elsewhere too?
There was a problem hiding this comment.
_start_server() logs at error level already.
run_es_notifier() looks like it would be vulnerable to the same thing. I have not seen it in the test failures, but that could be because tests don't stop/start elastic sync a lot.
I haven't been able to determine whether there are other transient error codes.
There was a problem hiding this comment.
Fixed run_es_notifier() in similar way. Added broad logging of Exception types.
moodyjon
force-pushed
the
eaddrinuse_retry
branch
from
3e5779a to
4ce3661
Compare
jackrobison
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
EADDRINUSE may appear in other tests or with other components, but I think this will fix the hub.herald.session one.