Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've added a menu to share when long-pressing a video #1222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

veritaslogix
Copy link

@veritaslogix veritaslogix commented Sep 29, 2021

Hi there!
I'm working on issue #1133 (#1133)

So far, it's going well. However, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.

To keep things simple, I used a popup menu. I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.

(Right now, "Share" is the only menu item that actually works.) Before I keep going, I was looking for some feedback on what I've done so far.

Thanks :)

[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1133

What is the current behavior?: Users have to click on a video to use options like sharing

What is the new behavior?: I added a menu so that when users click on a video they can share it without actually clicking on it

Other information

@veritaslogix veritaslogix changed the title 09.29.2021 popup menu Feature request: Option to share when long-pressing a video #1133 Sep 29, 2021
@veritaslogix veritaslogix changed the title Feature request: Option to share when long-pressing a video #1133 I've added a menu to share when long-pressing a video (#1133) Sep 29, 2021
@veritaslogix veritaslogix changed the title I've added a menu to share when long-pressing a video (#1133) I've added a menu to share when long-pressing a video Sep 29, 2021
@kekkyojin
Copy link
Collaborator

Please, rebase your branch so it is a child from commit ca08f7, latest one you pulled from LBRY-android repository.

By adding a commit to your master branch and then creating a new branch from it, this PR includes that commit, which is unrelated to the feature you are trying to merge to lbry—android.

Then you will need to force-push to your remote. GitHub will likely update automatically this PR.

@veritaslogix
Copy link
Author

Okay thanks! So, I've made a new branch to my master branch and rebased this branch to it. Did I understand what you wanted me to do correctly?

@kekkyojin
Copy link
Collaborator

kekkyojin commented Sep 30, 2021

Run these commands one by one from master branch:

git checkout 09.29.2021-popup_menu
git rebase --onto ca08f71 159494

And then verify project still builds. Once code has built, run following command, using the id you have setup as your remote (use git remote to see it):

git push -f YOUR_REMOTE_HERE 09.29.2021-popup_menu

This will update your remote branch and GitHub will also show the forced-push and update the commits, now showing only two.

pixel added 2 commits October 1, 2021 17:34
…o#1133.

 (lbryio#1133)

 So far, I've located the longClick method in the claimadapter.
 I put some Log.d messages to confirm that I can do something when I long press.
 Evreything's working so it looks like I can progress to implement a menu kind of selection for sharing.
…o#1133.

 (lbryio#1133)

 So far, I've got it working pretty well. Now, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.

 To keep things simple, I used a popup menu. Now, I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.

 "Share" is the only menu item that actually works right now.
@veritaslogix
Copy link
Author

@kekkyojin you are 100% radical. Thank you so much for helping me with that. I just ran those commands they worked perfectly! Thanks!

@veritaslogix
Copy link
Author

veritaslogix commented Oct 1, 2021

Please let me know if there's anything you need or if you'd like me to explain my choices in the changes I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants