Fix uncaught reflector connection errors #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackrobison
added
type: bug
jackrobison
force-pushed
the
fix-reflector-lost-connection
branch
from
9c4178f
to
1f82a8b
Compare
This was
linked to
issues
Jul 16, 2020
|
This is working great so far! |
eukreign
requested changes
Jul 20, 2020
| self.chunk_size = response_chunk_size | ||
| self.wait_for_stop_task: typing.Optional[asyncio.Task] = None |
There was a problem hiding this comment.
the Optional is not necessary here since it's being set to None
eukreign
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.