Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve code quality #3245

Merged
merged 7 commits into from
Apr 7, 2021
Merged

improve code quality #3245

merged 7 commits into from
Apr 7, 2021

Commits on Apr 7, 2021

  1. Remove unnecessary comprehension 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    6378641 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary use of comprehension 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    6da87d3 View commit details
    Browse the repository at this point in the history

  3. Remove methods with unnecessary super delegation. 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    1bb23d1 View commit details
    Browse the repository at this point in the history

  4. Iterate dictionary directly 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3fcb322 View commit details
    Browse the repository at this point in the history

  5. Refactor the comparison involving not 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f42795d View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary generator 

    Signed-off-by: shubhendra <withshubh@gmail.com>
    @withshubh @eukreign
    withshubh authored and eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    9f4b715 View commit details
    Browse the repository at this point in the history

  7. lint

    @eukreign
    eukreign committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    2006ac2 View commit details
    Browse the repository at this point in the history