Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict udp sources, add ALLOW_LAN_UDP hub setting #3285

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Restrict udp sources, add ALLOW_LAN_UDP hub setting #3285

merged 3 commits into from
Apr 29, 2021

Conversation

jackrobison
Copy link
Member

  • drop DHT and hub ping requests from a source port of under 1024, normal clients shouldn't be able to send these
  • add a sanity check for bogon and reserved source ips to the hub ping server
  • add ALLOW_LAN_UDP hub setting to allow hub clients from lan ips

@jackrobison jackrobison added type: improvement Existing (or partially existing) functionality needs to be changed area: hub labels Apr 28, 2021
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Apr 28, 2021
@jackrobison jackrobison merged commit cb5dab3 into master Apr 29, 2021
@jackrobison jackrobison deleted the restrict-udp-source branch April 29, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyba shyba shyba approved these changes

Assignees

@jackrobison jackrobison

Labels
area: hub type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackrobison @shyba