Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set stream as reflected until reflector says it doesn't need any blob #3308

Merged
merged 5 commits into from
May 27, 2021
Merged

Don't set stream as reflected until reflector says it doesn't need any blob #3308

merged 5 commits into from
May 27, 2021

Conversation

shyba
Copy link
Member

@shyba shyba commented May 20, 2021

closes #3296

@shyba shyba requested a review from jackrobison May 20, 2021 22:02
@shyba shyba mentioned this pull request May 20, 2021
Closed
@shyba shyba added area: blobs/files type: bug Existing functionality is wrong or broken labels May 20, 2021
@jackrobison jackrobison merged commit 099f3b6 into master May 27, 2021
@jackrobison jackrobison deleted the reflect_more branch May 27, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackrobison jackrobison Awaiting requested review from jackrobison

Assignees

@jackrobison jackrobison

Labels
area: blobs/files type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all blobs accounted for on reflection for larger files
2 participants
@shyba @jackrobison