scripts: note to further investigate in download_blob_from_peer
#3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belikor
force-pushed
the
note-download-blob-peer
branch
from
a6f3b7a
to
fed49c4
Compare
Currently `lbrynet blob get <hash>` does not work to download single blobs which are not already present in the system. The function locks up and never returns. It only works for blobs that are in the `blobfiles` directory already. This bug is reported in lbryio/lbry-sdk, issue lbryio#2070. Maybe this script can be investigated, and certain parts can be added to `lbry.extras.daemon.daemon.jsonrpc_blob_get` in order to solve the previous issue, and finally download single blobs from the network (peers or reflector servers).
belikor
force-pushed
the
note-download-blob-peer
branch
from
fed49c4
to
4ebe4ce
Compare
|
thanks @belikor 👍 |
10 tasks
eukreign
added
area: other
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
lbrynet blob get <hash>does not work to download single blobs which are not already present in the system.The function locks up and never returns.
It only works for blobs that are in the
blobfilesdirectory already.This bug is reported in lbryio/lbry-sdk, issue #2070.
Since this script does in fact allow downloading an arbitrary blob, we may decide to copy parts of it and add them to
lbry.extras.daemon.daemon.jsonrpc_blob_getin order to solve the previous issue.