Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error handling when fetching exchange rate from UPbit #3361

Merged
merged 1 commit into from
Jul 19, 2021

Commits on Jul 19, 2021

  1. exchange_rate_manager: raise exception if 'error' is in `json_respo…

    …nse`
    
    If the error is not handled, the running daemon will continuously
    print the following error message:
    ```
    Traceback (most recent call last):
      File "lbry/extras/daemon/exchange_rate_manager.py", line 77, in get_rate
      File "lbry/extras/daemon/exchange_rate_manager.py", line 189, in get_rate_from_response
    KeyError: 0
    ```
    
    This started happening when the UPBit exchange decided to delist
    the LBC coin.
    
    Normally `json_response` should be a dictionary, not a list,
    so `json_response[0]` causes an error.
    
    By checking for the `'error'` key, we can raise the proper exception.
    
    Once this is done, the message will be a warning, not a traceback.
    ```
    WARNING  lbry.extras.daemon.exchange_rate_manager:92:
    Failed to get exchange rate from UPbit: result not found
    ```
    belikor authored and eukreign committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    9250d7d View commit details
    Browse the repository at this point in the history