Golang claim search rebased and fixes #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
changed the title
shyba
force-pushed
the
golang_claim_search_rebased
branch
2 times, most recently
from
336f6c9
to
bb996d0
Compare
shyba
force-pushed
the
golang_claim_search_rebased
branch
from
11bcb41
to
091b72b
Compare
shyba
force-pushed
the
golang_claim_search_rebased
branch
4 times, most recently
from
571b59d
to
fcd03a3
Compare
shyba
changed the title
shyba
force-pushed
the
golang_claim_search_rebased
branch
3 times, most recently
from
3f7772e
to
6c76a30
Compare
eukreign
requested changes
Sep 8, 2021
eukreign
approved these changes
Sep 9, 2021
Have the basic starting /stopping / querying. Still don't have the hub jsonrpc stuff working right and from the looks of it I need to clearify some of the logic in the claim search function itself because it's not returning the correct number of claims anyways. get the integration working with grpcurl Got tests working, still need to port the rest of them ported all of the claim search tests still a few failing due to not having inflation working, and there's something weird with limit_claims_per_channel that needs to be fixed.
Fixing tests relabel failing tests properly run all the tests for the hub cleanup HubNode
more protobuf changes (fix imports)
Cleanup prints and commented out code remove print don't do list claims cleanup
|
@shyba if this is ready to be merged, please merge |
jackrobison
reviewed
Sep 10, 2021
shyba
force-pushed
the
golang_claim_search_rebased
branch
from
3822aff
to
753a7a5
Compare
eukreign
added
area: hub
type: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3393
based on #3314