removed comment API endoints
#3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Removed the comment API Removed tests for the comment API Removed the documentation section Removed the comment server configuration
cristi-zz
force-pushed
the
remove_comment_api
branch
from
4e2bc31
to
8362640
Compare
Refactored dangling functions. Added unit test.
Refresh documentation.
cristi-zz
force-pushed
the
remove_comment_api
branch
from
8362640
to
e1e7600
Compare
shyba
approved these changes
Sep 9, 2021
eukreign
added
area: api
type: refactor
|
Will be there any replacement for this? |
|
we will keep using Odysee comment system in the app. no login required - comments are signed using channel keys. this is what the sdk was already doing underneath, so removing these APIs is just about clarifying that the comments are not part of the lbry protocol. we would like to do federated comments as part of the protocol down the road |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the comment API
Removed tests for the comment API
Removed the documentation section
Removed the comment server configuration