-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout of async operations to integration test setup/teardown #3490
Conversation
@femtosecondlaser thanks for this PR! the tests don't seem to be passing... also, where does i think we always want all tests to have a timeout, there should be some default timeout set (how about 30 seconds)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIMEOUT
should be set to a default value somewhere and we always want the timeout enabled, unless you can think of a reason a test might not want to have a timeout?
TIMEOUT is set to 120 sec here. It has been there for timing out async operations in the main body of the tests. I extended the usage for startup and cleanup parts of the tests. |
@eukreign |
pull request addressing the issue #3482
Had a look at the causes of the 6h pipeline runs (such as this) - appeared to be async operations in the test cleanup procedure. This change adds timeout to the setup and cleanup of the integration tests.
Is it known why the operations were getting stuck? If not - could more logging be added to look into this problem further?