-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metrics for DHT internals #3500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
force-pushed
the
fix_script
branch
2 times, most recently
from
December 6, 2021 20:50
af6c669
to
abaa20f
Compare
shyba
force-pushed
the
fix_script
branch
2 times, most recently
from
December 14, 2021 21:18
748d748
to
41e1368
Compare
shyba
force-pushed
the
fix_script
branch
3 times, most recently
from
December 23, 2021 21:30
d26bc1e
to
503177b
Compare
shyba
changed the title
Update dht script for network size estimation endpoints
Add Prometheus metrics for DHT internals
Dec 24, 2021
shyba
force-pushed
the
fix_script
branch
2 times, most recently
from
January 7, 2022 16:31
baa965b
to
f689a97
Compare
|
jackrobison
added
type: new feature
New functionality that does not exist yet
area: DHT
type: improvement
Existing (or partially existing) functionality needs to be changed
and removed
type: new feature
New functionality that does not exist yet
labels
Mar 4, 2022
jackrobison
changed the title
Add Prometheus metrics for DHT internals
Add prometheus metrics for DHT internals
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK already supports exporting metrics over Prometheus if the user wishes to do so. This PR adds the following metrics under the
dht_node
namespace:data store
stored_blobs_x_bytes_colliding
: Number of blobs with at least X bytes colliding with this node id prefixsd_hash
param toclaim_search
#3511 merged.stored_blobs
: Number of blobs announced by other peersstoring_peers
: Number of peers storing blobs announced to this nodeprotocol
peer_manager_keys
: Number of keys tracked by PeerManager dicts (sum)request_sent
: Number of requests send from DHT RPC protocolrequest_success
: Number of successful requestsrequest_error
: Number of errors returned from request to other peersresponse_time
: Response times of DHT RPC requestsreceived_request
: Number of received DHT RPC requestsrouting table
peers_in_routing_table
: Number of peers on routing tablepeer_x_bit_colliding
: Number of peers with at least X bits colliding with this node idbuckets_in_routing_table
: Number of buckets on routing tableNew endpoints:
When starting the seed node script with
--metrics_port=<some_port>
, a web server will expose the following endpoints:/metrics
: Prometheus endpoint with the above metrics.If desired, routing table peers and announced blobs can be exported in CSV format using
--enable_csv_export
. However, you should use a firewall and avoid exposing that publicly as the announced blobs list can reach multiple thousands items, easily bringing your server down by malicious users./peers.csv
: All peers from the routing table in CSV format (ip, port, node_id)/blobs.csv
: All blobs announced to the node in CSV format (hex encoded blob hash)