Improvements and bug fixes for iterative find #3559
Merged
+171
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
force-pushed
the
dht_bug
branch
2 times, most recently
from
595c27f
to
f2c823e
Compare
shyba
force-pushed
the
dht_bug
branch
5 times, most recently
from
61bfb39
to
64ef302
Compare
shyba
added
area: DHT
type: improvement
shyba
force-pushed
the
dht_bug
branch
2 times, most recently
from
d8c3964
to
d00b5be
Compare
jackrobison
reviewed
Feb 21, 2022
| self.prev_closest_peer = self.closest_peer | ||
| self.closest_peer = peer | ||
| self.active[peer] = self.distance(peer.node_id) | ||
| self.active = OrderedDict(sorted(self.active.items(), key=lambda item: item[1])) |
There was a problem hiding this comment.
instead of remaking the ordered dict you could use an always-sorted list that you insort into
jackrobison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backwards-incompatible: removed unused
search_bottom_out_limitfrompeer listAPI (it was ignored before and got removed entirely from internals)