Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster on-demand (instead of batched) announcement of blob hashes #3563

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Faster on-demand (instead of batched) announcement of blob hashes #3563

merged 1 commit into from
Feb 21, 2022

Conversation

shyba
Copy link
Member

@shyba shyba commented Feb 9, 2022 •
edited
Loading

Makes the hash announcer consume from a queue instead of just gathering batches (we were pausing for each gather, instead this gather consumers for a queue)

@shyba shyba force-pushed the new_hash_announcer branch from ea0455e to 5eb9cc9 Compare February 9, 2022 00:57
@coveralls
Copy link

coveralls commented Feb 9, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 70.176% when pulling 4ecd2cb on new_hash_announcer into bfaf1b0 on master.

@shyba shyba force-pushed the new_hash_announcer branch from bfda82b to 77daf6d Compare February 15, 2022 03:55
@shyba shyba force-pushed the new_hash_announcer branch from 77daf6d to 4ecd2cb Compare February 19, 2022 05:51
@shyba shyba requested a review from jackrobison February 19, 2022 05:51
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Feb 19, 2022
@shyba shyba marked this pull request as ready for review February 19, 2022 05:51
@shyba shyba changed the base branch from master to dht_bug February 21, 2022 01:26
@shyba shyba added area: DHT type: improvement Existing (or partially existing) functionality needs to be changed labels Feb 21, 2022
@shyba
Copy link
Member Author

shyba commented Feb 21, 2022

since it depends on dht_bug, I changed the base there and will merge to unify the PRs

@shyba shyba merged commit d8c3964 into dht_bug Feb 21, 2022
@shyba shyba deleted the new_hash_announcer branch February 21, 2022 01:30
@jackrobison jackrobison changed the title DHT: make hash announcer use consumers instead of gathering batches Faster on-demand (instead of batched) announcement of blob hashes Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackrobison jackrobison Awaiting requested review from jackrobison

Assignees

@jackrobison jackrobison

Labels
area: DHT type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyba @coveralls @jackrobison