Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling re-adding lost peers during download #3564

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

shyba
Copy link
Member

@shyba shyba commented Feb 9, 2022

re_add doesn't seem to do anything. I was debugging and we lose a lot of peers there. Running with that so far is way better, but I'm not sure why we had that code. I think that got lost during a refactor or rebase.

@shyba shyba added type: bug Existing functionality is wrong or broken area: blob exchange labels Feb 9, 2022
@shyba shyba requested a review from jackrobison February 9, 2022 00:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.751% when pulling bb60c38 on fix_downloader_losing_peers into c96d1d9 on master.

@lbry-bot lbry-bot assigned shyba and unassigned jackrobison Feb 16, 2022
@jackrobison jackrobison changed the title blob_exchange: put back all the peers, fix case where they would be lost fix handling re-adding lost peers during download Feb 16, 2022
@jackrobison jackrobison merged commit bfaf1b0 into master Feb 16, 2022
@jackrobison jackrobison deleted the fix_downloader_losing_peers branch February 16, 2022 16:55
@jackrobison jackrobison changed the title fix handling re-adding lost peers during download Fix handling re-adding lost peers during download Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: blobs/files type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants